[Mesa-dev] [PATCH 3/3] glsl: fix typos in comments "transfor" -> "transform"

[Chema Casanova]

On 21/11/18 20:07, Ilia Mirkin wrote:
> Oh, yay, you fixed the typos here. I just had to keep reading.
> 
> This patch is obviously
> 
> Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

Thanks.

> 
> For the others ... have you run these through intel's CI?

> I'm interested in verifying that dEQP, CTS, and piglit all remain happy
> with the changes.

Yes. The CI is happy for dEQP, OpenGL CTS and piglit.

https://mesa-ci.01.org/jmcasanova/builds/13/group/63a9f0ea7bb98050796b649e85481845

It detects a regression not related to my changes in vulkancts on BDW
dEQP-VK.­subgroups.­shuffle.­subgroupshuffleup_bvec4_graphic, but in my
BDW it is a pass. (I've just resent the series to confirm it).

> The program resource stuff took a while to nail down
> properly (and it seems like we're discovering issues to this very
> day).

Yes, it took me a while to reduce the change as much as possible to
avoid changing current behavior except for these test cases. They are
corner cases that are not really useful in a real program as data can
not be used because we don't support NV_gpu_shader5 extension.

Thanks for checking the series.

>   -ilia
> On Wed, Nov 21, 2018 at 1:46 PM Jose Maria Casanova Crespo
> <jmcasanova at igalia.com> wrote:
>>
>> ---
>>  src/compiler/glsl/ir.h | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/compiler/glsl/ir.h b/src/compiler/glsl/ir.h
>> index e09f053b77c..c3f5f1f7b05 100644
>> --- a/src/compiler/glsl/ir.h
>> +++ b/src/compiler/glsl/ir.h
>> @@ -773,17 +773,17 @@ public:
>>        unsigned is_xfb_per_vertex_output:1;
>>
>>        /**
>> -       * Was a transfor feedback buffer set in the shader?
>> +       * Was a transform feedback buffer set in the shader?
>>         */
>>        unsigned explicit_xfb_buffer:1;
>>
>>        /**
>> -       * Was a transfor feedback offset set in the shader?
>> +       * Was a transform feedback offset set in the shader?
>>         */
>>        unsigned explicit_xfb_offset:1;
>>
>>        /**
>> -       * Was a transfor feedback stride set in the shader?
>> +       * Was a transform feedback stride set in the shader?
>>         */
>>        unsigned explicit_xfb_stride:1;
>>
>> --
>> 2.19.1
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>