[Mesa-dev] [PATCH] anv: allow exporting an imported SYNC_FD semaphore type

[Tapani Pälli]

Hi;

On 11/22/18 6:20 PM, Emil Velikov wrote:
> On 2018/11/22, Tapani Pälli wrote:
>> Fixes issues with following SkQP tests:
>>
>>     unitTest_VulkanHardwareBuffer_Vulkan_EGL_Syncs
>>     unitTest_VulkanHardwareBuffer_Vulkan_Vulkan_Syncs
>>
>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>> ---
>>   src/intel/vulkan/anv_queue.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/intel/vulkan/anv_queue.c b/src/intel/vulkan/anv_queue.c
>> index 2a8ed2eb4ed..7887fbcb937 100644
>> --- a/src/intel/vulkan/anv_queue.c
>> +++ b/src/intel/vulkan/anv_queue.c
>> @@ -1056,7 +1056,8 @@ void anv_GetPhysicalDeviceExternalSemaphoreProperties(
>>   
>>      case VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT:
>>         if (device->has_exec_fence) {
>> -         pExternalSemaphoreProperties->exportFromImportedHandleTypes = 0;
>> +         pExternalSemaphoreProperties->exportFromImportedHandleTypes =
>> +            VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT;
>>            pExternalSemaphoreProperties->compatibleHandleTypes =
>>               VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT;
>>            pExternalSemaphoreProperties->externalSemaphoreFeatures =
>> -- 
> Hi Tapani,
> 
> Is it Worth picking this for stable?
> 

Nope, as it exposes a new capability. I believe these tests should be 
made to skip earlier if this capability is not available, currently they 
realize it too late and fail in horrible ways. Will try to apply some 
fix there also.

// Tapani