[Mesa-dev] [PATCH 0/6] Use common code for gallium array setup.

Mathias.Froehlich at gmx.net Mathias.Froehlich at gmx.net
Fri Nov 23 08:07:26 UTC 2018


From: Mathias Fröhlich <Mathias.Froehlich at gmx.net>

Hi,

The series unifies functions for array setup into gallium.
Instead of just walking all VAO attributes we can make use of
the enabled and required attribute arrays also for feedback
rendering.
Along that way cleanup duplicate references and unneeded
calls to the uploader.
Beside unifying common code, the series prepare the gallium
side of the removal of intermediately introduced methods
for VAO/current value array access.

The changes were tested with llvmpipe and radeonsi and piglit
without regresseions by this series.

please review

Thanks in advance and best
Mathias



Mathias Fröhlich (6):
  mesa/st: Only care about the uploader if it was used.
  mesa/st: Only unmap the uploader that was actually used.
  mesa/st: Factor out array and buffer setup from st_atom_array.c.
  mesa/st: Avoid extra references in the feedback draw function scope.
  mesa/st: Use binding information from the VAO in feedback rendering.
  mesa/st: Make st_pipe_vertex_format static.

 src/mesa/state_tracker/st_atom.h          |  27 ++++-
 src/mesa/state_tracker/st_atom_array.c    | 116 +++++++++++++++++-----
 src/mesa/state_tracker/st_draw_feedback.c |  94 ++++++------------
 3 files changed, 146 insertions(+), 91 deletions(-)

-- 
2.17.2



More information about the mesa-dev mailing list