[Mesa-dev] [PATCH 2/2] radv: correctly use vulkan 1.0 by default

[Bas Nieuwenhuizen]

On Fri, Nov 23, 2018 at 6:24 PM Eric Engestrom <eric.engestrom at intel.com> wrote:
>
> On Friday, 2018-11-23 00:32:29 +0100, Niklas Haas wrote:
> > From the vulkan spec 3.2 "Instances":
> >
> > "Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an
> > apiVersion of 0 is equivalent to providing an apiVersion of
> > VK_MAKE_VERSION(1,0,0)."
> > ---
> >  src/amd/vulkan/radv_device.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> > index 70084a2b60..c258599888 100644
> > --- a/src/amd/vulkan/radv_device.c
> > +++ b/src/amd/vulkan/radv_device.c
> > @@ -525,7 +525,7 @@ VkResult radv_CreateInstance(
> >           pCreateInfo->pApplicationInfo->apiVersion != 0) {
> >               client_version = pCreateInfo->pApplicationInfo->apiVersion;
> >       } else {
> > -             radv_EnumerateInstanceVersion(&client_version);
> > +             client_version = VK_API_VERSION_1_0;
>
> This is essentially reverting Bas' (cc'ed) ffa15861ef7c924a33e1f, so:
> Fixes: ffa15861ef7c924a33e1f "radv: UseEnumerateInstanceVersion for the default version."
>
> Bas, I double-checked the spec and Niklas is right; why did you change
> it to use the icd version instead? Was is fixing an issue somewhere?

Copying behavior from ANV ;)

No objections here, feel free to push with Reviewed-by: Bas
Nieuwenhuizen <bas at basnieuwenhuizen.nl>
>
> Unless Bas objects, this is:
> Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
>
> >       }
> >
> >       instance = vk_zalloc2(&default_alloc, pAllocator, sizeof(*instance), 8,
> > --
> > 2.19.1
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev