[Mesa-dev] [PATCH 12/18] meson: wire the new generator for es1 and es2

[Dylan Baker]

Quoting Emil Velikov (2018-11-23 05:26:18)
> On 2018/11/21, Dylan Baker wrote:
> 
> > > diff --git a/src/mapi/glapi/gen/meson.build b/src/mapi/glapi/gen/meson.build
> > > index f494e9707b6..fa06c7c5458 100644
> > > --- a/src/mapi/glapi/gen/meson.build
> > > +++ b/src/mapi/glapi/gen/meson.build
> > > @@ -18,6 +18,13 @@
> > >  # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
> > >  # SOFTWARE.
> > >  
> > > +glapi_gen_gl_xml = files('../registry/gl.xml')
> > 
> > the gl_enum.py generate could use this as well.
> > 
> Not sure what you mean here. I cannot find any file called gl_enum.py
> and `git grep gl_enum.py` returns nothing.

I may have mis-remembered the name, grep file files('../registre/gl.xml'),
there's another case of this in that meson.build file that could be replaced
with the glapi_gen_gl_xml variable.

> 
> > > +glapi_gen_mapi_deps = [
> > > +  glapi_gen_gl_xml,
> > > +  files('../../new/genCommon.py'),
> > > +  glapi_gen_gl_xml,
> > > +]
> > > +
> > >  gl_and_es_api_files = files('gl_and_es_API.xml')
> > >  
> > >  api_xml_files = files(
> > > diff --git a/src/mapi/meson.build b/src/mapi/meson.build
> > > index 798586bfb0c..e7a6685576b 100644
> > > --- a/src/mapi/meson.build
> > > +++ b/src/mapi/meson.build
> > > @@ -25,6 +25,7 @@ files_mapi_util = files(
> > >    'u_execmem.h',
> > >  )
> > >  
> > > +glapi_gen_mapi_script = files('new/gen_gldispatch_mapi.py')
> > 
> > All of the other generated scripts are "${foo}_py", can we continue to use that
> > format please?
> > 
> Sure thing. To keep things obvious, I've left them identical for across
> all builds.
> 
> Thanks
> Emil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181123/5ffea345/attachment-0001.sig>