[Mesa-dev] [PATCH mesa 2/2] build: stop defining unused VERSION

[Dylan Baker]

Quoting Eric Engestrom (2018-11-25 09:11:57)
> Scons and autotools don't define it, and as of last commit nothing
> uses it.
> 
> `VERSION` is also a generic enough name that something somewhere will
> eventually clash, and we don't want to repeat the LLVM `DEBUG` fiasco.
> 
> Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
> ---
>  Android.common.mk | 1 -
>  meson.build       | 3 +--
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/Android.common.mk b/Android.common.mk
> index 25a3838bbc07784c5ca4..db21dcf26c65364188a2 100644
> --- a/Android.common.mk
> +++ b/Android.common.mk
> @@ -38,7 +38,6 @@ LOCAL_CFLAGS += \
>         -Wno-missing-field-initializers \
>         -Wno-initializer-overrides \
>         -Wno-mismatched-tags \
> -       -DVERSION=\"$(MESA_VERSION)\" \
>         -DPACKAGE_VERSION=\"$(MESA_VERSION)\" \
>         -DPACKAGE_BUGREPORT=\"https://bugs.freedesktop.org/enter_bug.cgi?product=Mesa\"
>  
> diff --git a/meson.build b/meson.build
> index 5a74943eb393bd3dd157..4ee40503d044a0985c89 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -43,8 +43,7 @@ pre_args = [
>    '-D__STDC_CONSTANT_MACROS',
>    '-D__STDC_FORMAT_MACROS',
>    '-D__STDC_LIMIT_MACROS',
> -  '-DVERSION="@0@"'.format(meson.project_version()),
> -  '-DPACKAGE_VERSION=VERSION',
> +  '-DPACKAGE_VERSION="@0@"'.format(meson.project_version()),
>    '-DPACKAGE_BUGREPORT="https://bugs.freedesktop.org/enter_bug.cgi?product=Mesa"',
>  ]
>  
> -- 
> Cheers,
>   Eric
> 

for the series:
Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181126/324c1b91/attachment.sig>