[Mesa-dev] [RFC 1/5] nir: Rename nir_op_fne to nir_op_fneu

Ian Romanick idr at freedesktop.org
Tue Nov 27 18:34:08 UTC 2018


On 11/26/2018 01:05 PM, Eric Anholt wrote:
> Jason Ekstrand <jason at jlekstrand.net> writes:
> 
>> This way, it's explicit in the opcode name that it's an unordered
>> comparison.
>> ---
>>  src/amd/common/ac_nir_to_llvm.c               |  2 +-
>>  src/compiler/glsl/glsl_to_nir.cpp             |  4 +-
>>  src/compiler/nir/nir.h                        |  2 +-
>>  src/compiler/nir/nir_builder.h                |  2 +-
>>  src/compiler/nir/nir_loop_analyze.c           |  4 +-
>>  src/compiler/nir/nir_lower_alu_to_scalar.c    |  2 +-
>>  src/compiler/nir/nir_lower_double_ops.c       |  6 +--
>>  src/compiler/nir/nir_opcodes.py               |  2 +-
>>  src/compiler/nir/nir_opt_algebraic.py         | 46 +++++++++----------
>>  src/compiler/spirv/vtn_alu.c                  | 10 ++--
>>  src/compiler/spirv/vtn_glsl450.c              |  4 +-
>>  src/gallium/auxiliary/nir/tgsi_to_nir.c       |  4 +-
>>  .../drivers/freedreno/ir3/ir3_compiler_nir.c  |  2 +-
>>  src/gallium/drivers/vc4/vc4_program.c         |  4 +-
>>  src/intel/compiler/brw_fs_nir.cpp             |  4 +-
>>  src/intel/compiler/brw_vec4_nir.cpp           |  4 +-
>>  16 files changed, 51 insertions(+), 51 deletions(-)
> 
> Looks like you missed src/broadcom/compiler/

I was going to suggest that this patch should just be a sed job, but...
It's a bummer that 'grep -rl nir_op_fne[^g] src/' doesn't produce the
full list.  It does get src/broadcom/compiler/nir_to_vir.c.

> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181127/621c5759/attachment.sig>


More information about the mesa-dev mailing list