[Mesa-dev] [PATCH mesa] wsi/display: fix mem leak when freeing swapchains

Keith Packard keithp at keithp.com
Tue Nov 27 20:45:28 UTC 2018


Eric Engestrom <eric.engestrom at intel.com> writes:

> Fixes: da997ebec92942193955 "vulkan: Add KHR_display extension using DRM [v10]"
> Cc: Keith Packard <keithp at keithp.com>
> Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>

Reviewed-by: Keith Packard <keithp at keithp.com>

I checked to ensure that this is sufficient to clean all allocated
objects:

 * Creating a display swapchain allocates the chain, image_count images
   and call wsi_swapchain_init. Adding the wsi_swapchain_finish cleans
   the last of these allocations.

 * The queue of to-be-presented images exists only as state values
   within the images themselves, so there's no additional allocation
   there.

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181127/793e1885/attachment.sig>


More information about the mesa-dev mailing list