[Mesa-dev] [PATCH] docs: Document optional GitLab code review process

[Jordan Justen]

On 2018-11-28 09:22:35, Dylan Baker wrote:
> Quoting Matt Turner (2018-11-27 19:20:09)
> > On Tue, Nov 27, 2018 at 5:13 PM Jordan Justen <jordan.l.justen at intel.com> wrote:
> > >
> > > This documents a mechanism for using GitLab Merge Requests as an
> > > optional, secondary way to get code reviews for patchsets.
> > >
> > > We still require all patches to be emailed.
> > >
> > > Aside from the potential usage for code review comments, it might also
> > > help reviewers to find unmerged patchsets which need review. (Assuming
> > > it doesn't fall into the same fate of patchwork with hundreds of open
> > > MRs.)
> > >
> > > Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> > > Cc: Jason Ekstrand <jason at jlekstrand.net>
> > > ---
> > >  docs/submittingpatches.html | 25 +++++++++++++++++++++++++
> > >  1 file changed, 25 insertions(+)
> > >
> > > diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html
> > > index 5d8ba443191..852f28c198a 100644
> > > --- a/docs/submittingpatches.html
> > > +++ b/docs/submittingpatches.html
> > > @@ -24,6 +24,7 @@
> > >  <li><a href="#testing">Testing Patches</a>
> > >  <li><a href="#mailing">Mailing Patches</a>
> > >  <li><a href="#reviewing">Reviewing Patches</a>
> > > +<li><a href="#gitlab">GitLab Merge Requests</a>
> > >  <li><a href="#nominations">Nominating a commit for a stable branch</a>
> > >  <li><a href="#criteria">Criteria for accepting patches to the stable branch</a>
> > >  <li><a href="#backports">Sending backports for the stable branch</a>
> > > @@ -282,6 +283,30 @@ which tells the patch author that the patch can be committed, as long
> > >  as the issues are resolved first.
> > >  </p>
> > >
> > > +<h2 id="gitlab">GitLab Merge Requests</h2>
> > > +
> > > +<p>
> > > +  <a href="https://gitlab.freedesktop.org/mesa/mesa">GitLab</a> Merge
> > > +  Requests (MR) can be used as an optional, secondary method of
> > > +  obtaining code review for patches.
> > > +</p>
> > > +
> > > +<ul>
> > > +  <li>All patches should be submitted using email as well
> > > +  <li>Consider including a link to the MR in your email based
> > > +    cover-letter
> > > +  <li>Address code review from both email and the MR
> > 
> > Discussion point: I think attempting to have simultaneous review in
> > two places is a recipe for wasted time. Strawman: maybe we can only
> > email the cover letter to the mailing list and include in it a link to
> > the MR?
> 
> I think it's a *really* bad idea to allow both. Some people will immediately
> begin using MR/PR's only and never read the list, others will never check
> MR/PRs and only use the list. It'll leave the rest of us forced to use both.

Requiring emails seems to avoid these issues for now. We'd just be
trying out using merge requests, but if you want to see all patches,
use email.

> We should either go all in and archive the mailing list and use only
> gitlab, or not use PR/MR's IMHO.

If that is the only choice, then I choose that we not use MR. Or, wait
until everyone is forced to try MR via other freedesktop projects. :)

One motivation I had for this patch was to see if MR could be a
'patchwork with labels'. Although, unlike patchwork, the contributor
would have to take an extra step to open the MR and apply the label.
One positive vs patchwork would be having the same login system as
Mesa's repo.

-Jordan