[Mesa-dev] [PATCH] anv: flush pipeline before query result copies

[Lionel Landwerlin]

On 29/11/2018 16:15, Jason Ekstrand wrote:
> On Thu, Nov 29, 2018 at 9:52 AM Józef Kucia <joseph.kucia at gmail.com 
> <mailto:joseph.kucia at gmail.com>> wrote:
>
>     On Thu, Nov 29, 2018 at 4:43 PM Lionel Landwerlin
>     <lionel.g.landwerlin at intel.com
>     <mailto:lionel.g.landwerlin at intel.com>> wrote:
>     >
>     > Pipeline barriers inserted through vkCmdPipelineBarrier() should be
>     > taken into account when copying results.
>     >
>     > In the particular bug below, the results of the
>     > vkCmdCopyQueryPoolResults() command was being overwritten by the
>     > preceding vkCmdCopyBuffer() with a same destination buffer. This is
>     > because we copy the buffers using the 3D pipeline whereas we
>     copy the
>     > query results using the command streamer. Those work in parallel
>     > unless synchronized.
>     >
>     > Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com
>     <mailto:lionel.g.landwerlin at intel.com>>
>     > Suggested-by: Jason Ekstrand <jason at jlekstrand.net
>     <mailto:jason at jlekstrand.net>>
>     > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108894
>
>     Thanks for the fix.
>
>     For what it's worth, we have more test failures on Anv. A lot failures
>     are related to clearing multisample array textures. See failures in
>     test_clear_render_target_view(), if you are interested.
>
>
> Mind filing a few bugs?  Feel free to bucket them such as "multisample 
> array texture clears".  How easy is it to run your tests?

Pretty easy.

Fetch http://source.winehq.org/git/vkd3d.git

Usual autotool compilation.

make tests/d3d12

I commented the tests I wasn't interested in for to make it easier and 
using vktrace to understand what's going on.


-

Lionel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181129/b2da710e/attachment.html>