[Mesa-dev] [PATCH] radv: disable HTILE for very small depth surfaces

[Samuel Pitoiset]

On 9/28/18 10:53 PM, Bas Nieuwenhuizen wrote:
> On Fri, Sep 28, 2018 at 4:27 PM Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>>
>> Like we disable DCC/CMASK for small color surfaces as well.
>> Serious Sam 2017 creates a 1x1 depth surface and I think
>> it should be faster to decompress compared to the benefit
>> of fast clears.
> 
> I don't think the last sentence rolls correctly, it seems to suggest
> that we are moving to doing a decompress operation, but with no HTILE
> we will never do that.

Yes, this is what I wanted to explain, not sure why I wrote that. Will 
update before pushing.

> 
> nit aside,
> 
> Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
>>
>> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
>> ---
>>   src/amd/vulkan/radv_image.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
>> index 658ccb65be..64346aa340 100644
>> --- a/src/amd/vulkan/radv_image.c
>> +++ b/src/amd/vulkan/radv_image.c
>> @@ -923,7 +923,9 @@ radv_image_can_enable_fmask(struct radv_image *image)
>>   static inline bool
>>   radv_image_can_enable_htile(struct radv_image *image)
>>   {
>> -       return image->info.levels == 1 && vk_format_is_depth(image->vk_format);
>> +       return image->info.levels == 1 &&
>> +              vk_format_is_depth(image->vk_format) &&
>> +              image->info.width * image->info.height >= 8 * 8;
>>   }
>>
>>   VkResult
>> --
>> 2.19.0
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev