[Mesa-dev] [PATCH] etnaviv: Use write combine instead of unached mappings for shader bo

Guido Günther agx at sigxcpu.org
Mon Oct 1 16:37:28 UTC 2018


The later are sensitive to unalligned accesses on arm64[1] and we don't
need an uncached mapping here.

[1]: https://lists.freedesktop.org/archives/etnaviv/2018-September/001956.html

Signed-off-by: Guido Günther <guido.gunther at puri.sm>
---
 src/gallium/drivers/etnaviv/etnaviv_shader.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/etnaviv/etnaviv_shader.c b/src/gallium/drivers/etnaviv/etnaviv_shader.c
index 04ababc801f..27c735b83bd 100644
--- a/src/gallium/drivers/etnaviv/etnaviv_shader.c
+++ b/src/gallium/drivers/etnaviv/etnaviv_shader.c
@@ -41,7 +41,7 @@ static bool etna_icache_upload_shader(struct etna_context *ctx, struct etna_shad
 {
    if (v->bo)
       return true;
-   v->bo = etna_bo_new(ctx->screen->dev, v->code_size*4, DRM_ETNA_GEM_CACHE_UNCACHED);
+   v->bo = etna_bo_new(ctx->screen->dev, v->code_size*4, DRM_ETNA_GEM_CACHE_WC);
    if (!v->bo)
       return false;
 
-- 
2.19.0


More information about the mesa-dev mailing list