[Mesa-dev] [PATCH mesa 1/3] include: sync eglplatform.h from Khronos

[Eric Engestrom]

On Tuesday, 2018-10-02 16:32:44 +0100, Emil Velikov wrote:
> Hi Eric,
> 
> On Sun, 10 Jun 2018 at 09:36, Eric Engestrom <eric at engestrom.ch> wrote:
> >
> > An issue [1] was recently raised with the upstream eglplatform.h, as my
> > upstreaming of the "X11 on Apple" resulted in Apple platforms to always
> > try to include X11 headers.
> >
> > The solution [2] was to also upstream our `MESA_EGL_NO_X11_HEADERS`
> > toggle, inverted as `USE_X11`.
> >
> > This commit updates our copy of the header, and updates the build system
> > to use the new define.
> >
> I'm a bit concerned that this will break apps which want to build with GLX/X11.
> Did you try building, say piglit/waffle (or more complex ones like
> dolphin/kodi) against the updated header?

I haven't (I'll try tomorrow), but I don't expect any other platform
than MacOS to change behaviour (where it will no longer include the X11
headers without being explicitly asked to).

> 
> Assuming that works, the patch is
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> 
> -Emil
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev