[Mesa-dev] [PATCH] meson: Don't allow building EGL on on KMS systems or Haiku

[Dylan Baker]

Quoting Emil Velikov (2018-10-03 09:42:32)
> On Wed, 3 Oct 2018 at 16:29, Dylan Baker <dylan at pnwbakers.com> wrote:
> >
> > Quoting Emil Velikov (2018-10-03 04:06:43)
> > > On Mon, 1 Oct 2018 at 20:44, Dylan Baker <dylan at pnwbakers.com> wrote:
> > > >
> > > > Currently mesa only supports EGL for KMS (Linux, *BSD) systems and
> > > > Haiku, we should actually enforce this. This fixes the default build on
> > > > MacOS.
> > >
> > > Currently you can build EGL on Linux, BSD, Cygwin and (most likely)
> > > exotic ones like GNU Hurd / NixOS.
> > > Not sure if meson handles all of those.
> > >
> > > If you what to explicitly disable it on macos, I'd reword the commit
> > > message to say that alone and omit the extra bits.
> > >
> > > -Emil
> >
> > Hurd is the only one I don't think we handle ATM, and maybe Solaris? Alan was
> > working on meson for Solaris but I think priorities at work changed. The
> > `system_has_drm_kms` should cover every platform mesa supports except MacOS,
> > Windows, and Haiku. Does that seem correct Emil?
> >
> The definition of "system_has_drm_kms" is orthogonal to EGL.
> Explaining one with the other makes things more confusing, than they
> already are.
> Please try to avoid that.
> 
> outside "system_has_drm_kms"
>  - Windows (msvc, mingw), MacOS, Cygwin, Haiku,  GNU Hurd
> within "system_has_drm_kms"
>  - Linux, BSD, NixOS and Solaris
> 
> "no" egl
>  - Windows (msvc, mingw) and MacOS
> has egl
>  - everything else
> 
> HTH
> Emil

Okay, that makes sense, I need to invert the patch then.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181003/6548586b/attachment.sig>