[Mesa-dev] [PATCH 4/5] virgl: handle dup failure.

Dave Airlie airlied at gmail.com
Fri Oct 5 00:00:36 UTC 2018


From: Dave Airlie <airlied at redhat.com>

This might never happen, but handle it better.

Found by coverity
---
 src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c b/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c
index 98e0e99f661..1b48b60d1fd 100644
--- a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c
+++ b/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c
@@ -930,6 +930,8 @@ virgl_drm_screen_create(int fd)
    } else {
       struct virgl_winsys *vws;
       int dup_fd = fcntl(fd, F_DUPFD_CLOEXEC, 3);
+      if (dup_fd == -1)
+         goto unlock;
 
       vws = virgl_drm_winsys_create(dup_fd);
       if (!vws) {
-- 
2.17.1



More information about the mesa-dev mailing list