[Mesa-dev] [PATCH mesa] radv: add missing meson c++ visibility arguments

Eric Engestrom eric.engestrom at intel.com
Tue Oct 9 13:24:48 UTC 2018


On Monday, 2018-10-08 08:45:18 -0700, Dylan Baker wrote:
> Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
> 
> You could add radv_flags to future safety, but it's not used currently so this
> should fix things.

Good point, thanks.
Added with your r-b and pushed :)

> 
> Quoting Eric Engestrom (2018-10-08 08:25:58)
> > Fixes: 6f3aee40f90d725653b6 "radv: using tls to store llvm related info
> >                              and speed up compiles (v10)"
> > Cc: Dave Airlie <airlied at redhat.com>
> > Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
> > ---
> >  src/amd/vulkan/meson.build | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/amd/vulkan/meson.build b/src/amd/vulkan/meson.build
> > index 9ceaeb6f00246f03b14a..87a90ffe849ad2baf346 100644
> > --- a/src/amd/vulkan/meson.build
> > +++ b/src/amd/vulkan/meson.build
> > @@ -144,6 +144,7 @@ libvulkan_radeon = shared_library(
> >      idep_nir,
> >    ],
> >    c_args : [c_vis_args, no_override_init_args, radv_flags],
> > +  cpp_args : cpp_vis_args,
> >    link_args : [ld_args_bsymbolic, ld_args_gc_sections],
> >    install : true,
> >  )
> > -- 
> > Cheers,
> >   Eric
> > 


More information about the mesa-dev mailing list