[Mesa-dev] [PATCH 1/2] anv/gen9+: Initialize new fields in STATE_BASE_ADDRESS

[Rafael Antognolli]

On Wed, Oct 10, 2018 at 01:39:25PM -0700, Jordan Justen wrote:
> Ref: 263b584d5e4 "i965/skl: Emit extra zeros in STATE_BASE_ADDRESS on Skylake."
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> ---
>  src/intel/vulkan/genX_cmd_buffer.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c
> index c3a7e5c83c3..43a02f22567 100644
> --- a/src/intel/vulkan/genX_cmd_buffer.c
> +++ b/src/intel/vulkan/genX_cmd_buffer.c
> @@ -121,6 +121,18 @@ genX(cmd_buffer_emit_state_base_address)(struct anv_cmd_buffer *cmd_buffer)
>        sba.IndirectObjectBufferSizeModifyEnable  = true;
>        sba.InstructionBufferSize                 = 0xfffff;
>        sba.InstructionBuffersizeModifyEnable     = true;
> +#  endif
> +#  if (GEN_GEN >= 9)
> +      sba.BindlessSurfaceStateBaseAddress = (struct anv_address) { NULL, 0 };
> +      sba.BindlessSurfaceStateMemoryObjectControlState = GENX(MOCS);
> +      sba.BindlessSurfaceStateBaseAddressModifyEnable = true;
> +      sba.BindlessSurfaceStateSize = 0;
> +#  endif
> +#  if (GEN_GEN >= 10)
> +      sba.BindlessSamplerStateBaseAddress = (struct anv_address) { NULL, 0 };
> +      sba.BindlessSamplerStateMemoryObjectControlState = GENX(MOCS);
> +      sba.BindlessSamplerStateBaseAddressModifyEnable = true;
> +      sba.BindlessSamplerStateBufferSize = 0;

Do we really need to set all of these fields? AFAIK the ones we don't
set should be left as 0's anyway, so at least the Address and BufferSize
should be fine to be left out. I think the MOCS field should be fine
too, since we are not setting any pointer here. Unless you want to
be really explicit...

>  #  endif
>     }
>  
> -- 
> 2.19.0
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev