[Mesa-dev] [PATCH 2/2] i965/gen10+: Initialize new fields in STATE_BASE_ADDRESS

[Rafael Antognolli]

On Wed, Oct 10, 2018 at 01:39:26PM -0700, Jordan Justen wrote:
> Ref: 263b584d5e4 "i965/skl: Emit extra zeros in STATE_BASE_ADDRESS on Skylake."
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_misc_state.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c b/src/mesa/drivers/dri/i965/brw_misc_state.c
> index 0895e1f2b7f..9bff2c8ac92 100644
> --- a/src/mesa/drivers/dri/i965/brw_misc_state.c
> +++ b/src/mesa/drivers/dri/i965/brw_misc_state.c
> @@ -688,7 +688,7 @@ brw_upload_state_base_address(struct brw_context *brw)
>         * to the bottom 4GB.
>         */
>        uint32_t mocs_wb = devinfo->gen >= 9 ? SKL_MOCS_WB : BDW_MOCS_WB;
> -      int pkt_len = devinfo->gen >= 9 ? 19 : 16;
> +      int pkt_len = devinfo->gen >= 10 ? 22 : (devinfo->gen >= 9 ? 19 : 16);
>  
>        BEGIN_BATCH(pkt_len);
>        OUT_BATCH(CMD_STATE_BASE_ADDRESS << 16 | (pkt_len - 2));
> @@ -718,6 +718,11 @@ brw_upload_state_base_address(struct brw_context *brw)
>           OUT_BATCH(0);
>           OUT_BATCH(0);
>        }
> +      if (devinfo->gen >= 10) {
> +         OUT_BATCH(1);
> +         OUT_BATCH(0);
> +         OUT_BATCH(0);
> +      }

Reviewed-by: Rafael Antognolli <rafael.antognolli at intel.com>

>        ADVANCE_BATCH();
>     } else if (devinfo->gen >= 6) {
>        uint8_t mocs = devinfo->gen == 7 ? GEN7_MOCS_L3 : 0;
> -- 
> 2.19.0
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev