[Mesa-dev] [Mesa-stable] [PATCH V2 6/6] util: disable cache if we have no build-id and timestamp is zero

[Timothy Arceri]

On 11/10/18 7:32 pm, Juan A. Suarez Romero wrote:
> On Wed, 2018-10-03 at 11:49 +0100, Emil Velikov wrote:
>> HI Tim,
>>
>> On Wed, 19 Sep 2018 at 23:55, Timothy Arceri <tarceri at itsqueeze.com> wrote:
>>>
>>> Timestamp can be zero for example when Flatpak is used. In this
>>> case just disable the cache rather then segfaulting when
>>> incompatible cache items are loaded.
>>>
>>> V2: actually return false when mtime is 0.
>>
>> Guessing that you've forgot to merge this patch alongside 1-5?
>>
>> Considering the crashes we'd want the whole series in stable, right?
>>
>> 6a884014e46 util: rename timestamp param in disk_cache_create()
>> 83ea8dd99bb util: add disk_cache_get_function_identifier()
>> 2169acbf34e radeonsi: use build-id when available for disk cache
>> 397f2603ebd nouveau: use build-id when available for disk cache
>> 2b5f42068d1 r600: use build-id when available for disk cache
>> + this patch
>>
> 
> 
> All the 6 patches enqueued for next 18.2 release.
> 
> One of the patches (2169acbf34e radeonsi: use build-id when available for disk
> cache) did not apply cleanly, so I've resolved the trivial conflicts.
> 
> The fixed patch is at
> https://gitlab.freedesktop.org/mesa/mesa/commit/61d782c39dc2b131f5a55f1adfbaad3fbaddb017
> 
> 
> Feel free to review it.

Thanks. Seems ok to me :)

> 
> 
> 	J.A.
> 
>> Thanks
>> Emil
>> _______________________________________________
>> mesa-stable mailing list
>> mesa-stable at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-stable
>