[Mesa-dev] [PATCH] i965: consider a 'base level' when calculating width0, height0, depth0

[Kenneth Graunke]

On Thursday, October 11, 2018 11:58:40 AM PDT Kenneth Graunke wrote:
> On Tuesday, October 2, 2018 9:16:01 AM PDT asimiklit.work at gmail.com wrote:
> > From: Andrii Simiklit <andrii.simiklit at globallogic.com>
> > 
> > I guess that when we calculating the width0, height0, depth0
> > to use for function 'intel_miptree_create' we need to consider
> > the 'base level' like it is done in the 'intel_miptree_create_for_teximage'
> > function.
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107987
> > Signed-off-by: Andrii Simiklit <andrii.simiklit at globallogic.com>
> > ---
> >  .../drivers/dri/i965/intel_tex_validate.c     | 26 ++++++++++++++++++-
> >  1 file changed, 25 insertions(+), 1 deletion(-)
> 
> I believe this patch is correct - we're assembling things into a new
> miptree, which we start at level 0 - so we need the sizes for level 0.

Oh, I should also mention...st_finalize_texture seems to do similar
shifting back up to get the base size.  So that's another piece of
evidence that we probably need this.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181011/2fc888b2/attachment.sig>