[Mesa-dev] [PATCH] r600/sb: Fix constant-logical-operand warning.

[Dave Airlie]

On Fri, 12 Oct 2018 at 07:16, Vinson Lee <vlee at freedesktop.org> wrote:
>
> sb/sb_bc_parser.cpp:620:27: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
>         if (cf->bc.op_ptr->flags && FF_GDS)
>                                  ^  ~~~~~~
> sb/sb_bc_parser.cpp:620:27: note: use '&' for a bitwise operation
>         if (cf->bc.op_ptr->flags && FF_GDS)
>                                  ^~
>                                  &
> sb/sb_bc_parser.cpp:620:27: note: remove constant to silence this warning
>         if (cf->bc.op_ptr->flags && FF_GDS)
>                                 ~^~~~~~~~~
>
> Fixes: da977ad90747 ("r600/sb: start adding GDS support")
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Oops,

Reviewed-by: Dave Airlie <airlied at redhat.com>

(not currently used as sb is disabled for tess shaders).

Dave.

> ---
>  src/gallium/drivers/r600/sb/sb_bc_parser.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/r600/sb/sb_bc_parser.cpp b/src/gallium/drivers/r600/sb/sb_bc_parser.cpp
> index eafc1cb8ec..90e6df745a 100644
> --- a/src/gallium/drivers/r600/sb/sb_bc_parser.cpp
> +++ b/src/gallium/drivers/r600/sb/sb_bc_parser.cpp
> @@ -617,7 +617,7 @@ int bc_parser::decode_fetch_clause(cf_node* cf) {
>         int r;
>         unsigned i = cf->bc.addr << 1, cnt = cf->bc.count + 1;
>
> -       if (cf->bc.op_ptr->flags && FF_GDS)
> +       if (cf->bc.op_ptr->flags & FF_GDS)
>                 cf->subtype = NST_GDS_CLAUSE;
>         else
>                 cf->subtype = NST_TEX_CLAUSE;
> --
> 2.17.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev