[Mesa-dev] [PATCH 1/3] mesa/core: Add support for EXT_sRGB_write_control

[Ilia Mirkin]

On Wed, Oct 17, 2018 at 12:49 PM Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Wed, Oct 17, 2018 at 12:38 PM Gert Wollny <gw.fossdev at gmail.com> wrote:
> > diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h
> > index 09bf923bd0..1185156f23 100644
> > --- a/src/mesa/main/extensions_table.h
> > +++ b/src/mesa/main/extensions_table.h
> > @@ -265,6 +265,7 @@ EXT(EXT_shader_integer_mix                  , EXT_shader_integer_mix
> >  EXT(EXT_shader_io_blocks                    , dummy_true                             ,  x ,  x ,  x ,  31, 2014)
> >  EXT(EXT_shader_samples_identical            , EXT_shader_samples_identical           , GLL, GLC,  x ,  31, 2015)
> >  EXT(EXT_shadow_funcs                        , ARB_shadow                             , GLL,  x ,  x ,  x , 2002)
> > +EXT(EXT_sRGB_write_control                  , EXT_sRGB_write_control                 , GLL,  x ,  x ,  30, 2013)
>
> I think you want an "x" instead of "GLL" -- it's an ES-only ext. Also
> I'd list "ES2" as the minimum. A driver that doesn't expose ES 3.0 or
> EXT_sRGB just shouldn't set this enable to true.

Oh, and an additional observation, since we don't expose EXT_sRGB at
all in mesa, the 30 is warranted here. But when we do, we should drop
this to ES2 and then ensure that the relevant drivers don't do
anything silly.

Cheers,

  -ilia