[Mesa-dev] [PATCH] freedreno: Fix emacs modeline

Eric Engestrom eric.engestrom at intel.com
Wed Oct 17 18:02:05 UTC 2018


On Wednesday, 2018-10-17 17:25:22 +0200, Neil Roberts wrote:
> Eric Engestrom <eric.engestrom at intel.com> writes:
> 
> > You might want to remove these instead, and use the .editorconfig [1]
> > already present at src/gallium/drivers/freedreno/.editorconfig This is
> > much easier to maintain than per-files settings ;)
> 
> Either fixing it or removing it is fine by me. I now notice there is a
> .dir-locals.el file that should make it work anyway. (apparently I was
> the last person to touch it too!) It has a typo which makes it fail to
> set indent-tabs-mode though. I can make everything work locally either
> way, I just wanted to get rid of the annoying warning whenever you open
> a file.

That's absolutely fair :)

I wanted to ack your patch earlier, since fixing it is good regardless,
but freedreno isn't my area so I didn't feel comfortable doing so;
I changed my mind in the mean time though, so here you go :P
Acked-by: Eric Engestrom <eric.engestrom at intel.com>

You have push access, right?

> 
> - Neil


More information about the mesa-dev mailing list