[Mesa-dev] correction: only regresses for Gallium drivers

Gert Wollny gert.wollny at collabora.com
Thu Oct 18 14:53:13 UTC 2018


Am Donnerstag, den 18.10.2018, 16:01 +0200 schrieb Gert Wollny:
> Ignore this series, there are regressions, at least 
> 
>   dEQP-GLES2.functional.texture.specification.
>     basic_copyteximage2d.2d_alpha
> 
> glCopyTexImage2D(srgb usage mismatch)

This regresses on gallium drivers (tested r600, llvmpipe, softpipe), on
Intel i965 it can be enabled, so the first and the third patch should
be okay, the second not. 

Best, 
Gert

> 
> Best, 
> Gert 
> 
> Am Donnerstag, den 18.10.2018, 10:46 +0200 schrieb Gert Wollny:
> > From: Gert Wollny <gert.wollny at collabora.com>
> > 
> > This is the updated version of the patches following Ilia's
> > pointers,
> > but also correcting some additional parts. 
> > 
> > Changes: 
> > 
> >  - core: Correct the extension table to list the extension as GLES
> > only
> >  - core: drop EXTRA_API_ES3, the requirements for get operations
> > listed
> >       here get OR-ed. (both Ilia Mirkin)
> >  - gallium: always enable the extension when sRGB is supported
> > (Ilia
> > Mirkin).
> >  - gallium: Correct handling by moving extension initialization to
> > the
> >      place where gallium/st actually takes care of this. This also
> >      fixes properly disabling the extension via
> > MESA_EXTENSION_OVERRIDE
> >  - gallium: reinstate check for desktop GL and add check for the
> > extension
> >      when creating the framebuffer
> >  - intel: Also text whether the extension is properly disabled by
> >      MESA_EXTENSION_OVERRIDE 
> > 
> > best, 
> > Gert
> > 
> > Gert Wollny (3):
> >   mesa/core: Add support for EXT_sRGB_write_control
> >   mesa/st: enable EXT_sRGB_write_control for drivers that support
> > it
> >   intel/i965: Enable extension EXT_sRGB_write_control
> > 
> >  src/mesa/drivers/dri/i965/intel_extensions.c |  1 +
> >  src/mesa/main/enable.c                       |  4 ++--
> >  src/mesa/main/extensions_table.h             |  1 +
> >  src/mesa/main/get.c                          |  5 +++++
> >  src/mesa/main/get_hash_params.py             |  1 +
> >  src/mesa/main/mtypes.h                       |  1 +
> >  src/mesa/state_tracker/st_extensions.c       |  6 ++++++
> >  src/mesa/state_tracker/st_manager.c          | 13 ++++++-------
> >  8 files changed, 23 insertions(+), 9 deletions(-)
> > 
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list