[Mesa-dev] [PATCH 2/3] anv: Stop generating weak references for instance entrypoints

[Jason Ekstrand]

On Thu, Oct 18, 2018 at 3:24 PM Jason Ekstrand <jason at jlekstrand.net> wrote:

> On Thu, Oct 18, 2018 at 3:17 PM Jan Vesely <jan.vesely at rutgers.edu> wrote:
>
>> Hi,
>>
>> I think this patch breaks the build:
>> https://travis-ci.org/jvesely/mesa/jobs/443356781
>>
>
> Interesting.  It appears that it breaks when you have one of the WSI
> extensions disabled.  I'll take a look.
>

Yeah, in retrospect, it's pretty bogus. I've reverted the patch.  Thanks
for reporting!  It was nice while it lasted because it pointed out an
entrypoint we forgot to implement but it looks like it was a bad idea in
the long term.  Maybe one day, I can come up with something more clever but
not today.

--jason



> --Jason
>
>
>
>> Jan
>>
>> On Tue, 2018-10-16 at 08:18 -0500, Jason Ekstrand wrote:
>> > FYI, patch 1 is required for this patch to build.  It also means this
>> patch
>> > found a nice little bug.  I'll respond to patch 1 in more detail after
>> the
>> > SI call tomorrow.
>> >
>> > --Jason
>> >
>> >
>> > On October 16, 2018 06:49:35 Lionel Landwerlin
>> > <lionel.g.landwerlin at intel.com> wrote:
>> >
>> > > Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>> > >
>> > > On 15/10/2018 04:47, Jason Ekstrand wrote:
>> > > > We don't need weak references to instance entrypoints because we
>> never
>> > > > have more than one of each so we don't need the NULL fall-back.
>> This
>> > > > also helps us avoid forgetting things because we now get link
>> errors for
>> > > > missing instance entrypoints.
>> > > > ---
>> > > >   src/intel/vulkan/anv_entrypoints_gen.py | 13 -------------
>> > > >   1 file changed, 13 deletions(-)
>> > > >
>> > > > diff --git a/src/intel/vulkan/anv_entrypoints_gen.py
>> > > > b/src/intel/vulkan/anv_entrypoints_gen.py
>> > > > index beb658b8660..25a532fd706 100644
>> > > > --- a/src/intel/vulkan/anv_entrypoints_gen.py
>> > > > +++ b/src/intel/vulkan/anv_entrypoints_gen.py
>> > > > @@ -227,19 +227,6 @@ ${strmap(device_strmap, 'device')}
>> > > >    * either pick the correct entry point.
>> > > >    */
>> > > >
>> > > > -% for e in instance_entrypoints:
>> > > > -  % if e.alias:
>> > > > -    <% continue %>
>> > > > -  % endif
>> > > > -  % if e.guard is not None:
>> > > > -#ifdef ${e.guard}
>> > > > -  % endif
>> > > > -  ${e.return_type} ${e.prefixed_name('anv')}(${e.decl_params()})
>> > > > __attribute__ ((weak));
>> > > > -  % if e.guard is not None:
>> > > > -#endif // ${e.guard}
>> > > > -  % endif
>> > > > -% endfor
>> > > > -
>> > > >   const struct anv_instance_dispatch_table
>> anv_instance_dispatch_table = {
>> > > >   % for e in instance_entrypoints:
>> > > >     % if e.guard is not None:
>> > >
>> > >
>> > > _______________________________________________
>> > > mesa-dev mailing list
>> > > mesa-dev at lists.freedesktop.org
>> > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>> >
>> >
>> >
>> > _______________________________________________
>> > mesa-dev mailing list
>> > mesa-dev at lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181018/a79110f9/attachment.html>