[Mesa-dev] [PATCH 3/3] Revert "radv: disable VK_SUBGROUP_FEATURE_VOTE_BIT"

[Samuel Pitoiset]

Can you wait until the CTS fix is upstream before pushing this please?


On 10/18/18 4:13 PM, Connor Abbott wrote:
> This reverts commit 647c2b90e96a9ab8571baf958a7c67c1e816911a. There was
> one recently-introduced bug in ac for dvec3 loads, but the other test
> failures were actually bugs in the tests. See
> https://github.com/cwabbott0/VK-GL-CTS/tree/voteallequal-fixes
> ---
>   src/amd/vulkan/radv_device.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> index 6eb37472992..4a705a724ef 100644
> --- a/src/amd/vulkan/radv_device.c
> +++ b/src/amd/vulkan/radv_device.c
> @@ -1057,14 +1057,12 @@ void radv_GetPhysicalDeviceProperties2(
>   			    (VkPhysicalDeviceSubgroupProperties*)ext;
>   			properties->subgroupSize = 64;
>   			properties->supportedStages = VK_SHADER_STAGE_ALL;
> -			/* TODO: Enable VK_SUBGROUP_FEATURE_VOTE_BIT when wwm
> -			 * is fixed in LLVM.
> -			 */
>   			properties->supportedOperations =
>   							VK_SUBGROUP_FEATURE_ARITHMETIC_BIT |
>   							VK_SUBGROUP_FEATURE_BASIC_BIT |
>   							VK_SUBGROUP_FEATURE_BALLOT_BIT |
> -							VK_SUBGROUP_FEATURE_QUAD_BIT;
> +							VK_SUBGROUP_FEATURE_QUAD_BIT |
> +							VK_SUBGROUP_FEATURE_VOTE_BIT;
>   			if (pdevice->rad_info.chip_class >= VI) {
>   				properties->supportedOperations |=
>   							VK_SUBGROUP_FEATURE_SHUFFLE_BIT |
>