[Mesa-dev] [PATCH 0/6] nir: Cleanups for opt_algebraic

Samuel Iglesias Gonsálvez siglesias at igalia.com
Mon Oct 22 11:25:00 UTC 2018

With the typo fix on patch 5/6 suggested by Matt, this patch series is:

Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>


On Saturday, 20 October 2018 20:01:28 (CEST) Jason Ekstrand wrote:
> This little series provides some cleanups for opt_algebraic.  The most
> important of which is adding descriptions to a bunch of the asserts in the
> bit-size checker.  I've only gotten through about half of it so there's
> still more work to do but it should make the error messages printed out
> much less opaque to the average reader.  I can't count the number of times
> in the last year or so that someone has come to me asking why their
> obviously correct optimization fails validation.  Hopefully, this will make
> working on nir_opt_algebraic even easier.
> Cc: Connor Abbott <cwabbott0 at gmail.com>
> Cc: Ian Romanick <idr at freedesktop.org>
> Jason Ekstrand (6):
>   nir/algebraic: Use bool internally instead of bool32
>   nir/algebraic: Generalize an optimization
>   nir/algebraic: Make internal classes str-able
>   nir/algebraic: A bit of validation refactoring
>   nir/algebraic: Losten a restriction on variables
>   nir/algebraic: Provide descriptive asserts for bit size checks
>  src/compiler/nir/nir_algebraic.py     | 107 ++++++++++++++++++--------
>  src/compiler/nir/nir_opt_algebraic.py |   2 +-
>  src/compiler/nir/nir_search.c         |   6 +-
>  3 files changed, 78 insertions(+), 37 deletions(-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181022/9beee51b/attachment.sig>

More information about the mesa-dev mailing list