[Mesa-dev] [PATCH 24/28] i965: use GLboolean for all brw_link_shader returns

Alejandro PiƱeiro apinheiro at igalia.com
Mon Oct 22 12:24:46 UTC 2018


The function had a mix of true/GL_TRUE and false/GL_FALSE
returns. Using GL_TRUE/GL_FALSE as the function returns a GLboolean.
---
 src/mesa/drivers/dri/i965/brw_link.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_link.cpp b/src/mesa/drivers/dri/i965/brw_link.cpp
index 37b775637b4..03b32d1fe7a 100644
--- a/src/mesa/drivers/dri/i965/brw_link.cpp
+++ b/src/mesa/drivers/dri/i965/brw_link.cpp
@@ -264,7 +264,7 @@ brw_link_shader(struct gl_context *ctx, struct gl_shader_program *shProg)
    /* SPIR-V programs use a NIR linker */
    if (shProg->data->spirv) {
       if (!gl_nir_link_uniforms(ctx, shProg))
-         return false;
+         return GL_FALSE;
 
       gl_nir_link_assign_atomic_counter_resources(ctx, shProg);
       gl_nir_link_assign_xfb_resources(ctx, shProg);
@@ -375,7 +375,7 @@ brw_link_shader(struct gl_context *ctx, struct gl_shader_program *shProg)
    }
 
    if (brw->precompile && !brw_shader_precompile(ctx, shProg))
-      return false;
+      return GL_FALSE;
 
    /* SPIR-V programs build its resource list from linked NIR shaders. */
    if (!shProg->data->spirv)
@@ -393,5 +393,5 @@ brw_link_shader(struct gl_context *ctx, struct gl_shader_program *shProg)
       shader->ir = NULL;
    }
 
-   return true;
+   return GL_TRUE;
 }
-- 
2.14.1



More information about the mesa-dev mailing list