[Mesa-dev] [PATCH 4/9] nir: Use nir_src_is_const and nir_src_as_* in core code

[Michel Dänzer]

Hi Jason,


this change caused an assertion failure for me during make check, in the
nir/tests/vars_tests test under src/compiler. See the attached backtrace.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
-------------- next part --------------
Core was generated by `./nir/tests/vars_tests'.
Program terminated with signal SIGABRT, Aborted.
#0  __GI_raise (sig=sig at entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
51	../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt
#0  __GI_raise (sig=sig at entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007fa17a3a62f1 in __GI_abort () at abort.c:79
#2  0x00007fa17a39da8a in __assert_fail_base (fmt=0x7fa17a4f1ec8 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion at entry=0x559a19a47c08 "nir_src_num_components(src) == 1", file=file at entry=0x559a19a477e0 "../../../src/compiler/nir/nir.c", 
    line=line at entry=1275, function=function at entry=0x559a19a48490 <__PRETTY_FUNCTION__.25988> "nir_src_as_uint") at assert.c:92
#3  0x00007fa17a39db02 in __GI___assert_fail (assertion=assertion at entry=0x559a19a47c08 "nir_src_num_components(src) == 1", file=file at entry=0x559a19a477e0 "../../../src/compiler/nir/nir.c", line=line at entry=1275, 
    function=function at entry=0x559a19a48490 <__PRETTY_FUNCTION__.25988> "nir_src_as_uint") at assert.c:101
#4  0x0000559a19a0ee64 in nir_src_as_uint (src=...) at ../../../src/compiler/nir/nir.c:1276
#5  0x0000559a199e3244 in nir_copy_prop_vars_test_store_store_load_different_components_Test::TestBody() () at ../../../src/compiler/nir/tests/vars_tests.cpp:378
#6  0x0000559a19a0be1e in testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void> (location=0x559a19a4468f "the test body", method=<optimized out>, object=0x559a19f20b60) at ../../../src/gtest/src/gtest.cc:2383
#7  testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void> (object=object at entry=0x559a19f20b60, method=<optimized out>, location=location at entry=0x559a19a4468f "the test body") at ../../../src/gtest/src/gtest.cc:2438
#8  0x0000559a19a023ba in testing::Test::Run (this=0x559a19f20b60) at ../../../src/gtest/src/gtest.cc:2474
#9  0x0000559a19a02508 in testing::TestInfo::Run (this=0x559a19f1f350) at ../../../src/gtest/src/gtest.cc:2656
#10 0x0000559a19a025e4 in testing::TestCase::Run (this=0x559a19f1ee90) at ../../../src/gtest/src/gtest.cc:2774
#11 0x0000559a19a02ad4 in testing::internal::UnitTestImpl::RunAllTests() () at /usr/include/c++/8/bits/stl_vector.h:930
#12 0x0000559a19a0c2fe in testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> (location=0x559a19a45830 "auxiliary test code (environments or event listeners)", method=<optimized out>, object=0x559a19f1e100)
    at ../../../src/gtest/src/gtest.cc:2383
#13 testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> (object=0x559a19f1e100, method=<optimized out>, location=location at entry=0x559a19a45830 "auxiliary test code (environments or event listeners)")
    at ../../../src/gtest/src/gtest.cc:2438
#14 0x0000559a19a02bc2 in testing::UnitTest::Run() () at ../../../src/gtest/include/gtest/gtest.h:1287
#15 0x0000559a199db934 in RUN_ALL_TESTS () at ../../../src/gtest/include/gtest/gtest.h:2233
#16 main (argc=<optimized out>, argv=0x7fffc3ee3048) at ../../../src/gtest/src/gtest_main.cc:37