[Mesa-dev] [PATCH mesa] anv: move variable to proper scope and mark as MAYBE_UNUSED

Lionel Landwerlin lionel.g.landwerlin at intel.com
Tue Oct 23 15:19:38 UTC 2018


Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

On 23/10/2018 15:37, Eric Engestrom wrote:
> Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
> ---
>   src/intel/vulkan/anv_queue.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_queue.c b/src/intel/vulkan/anv_queue.c
> index db89385b86644417d47a..05739cb26df571c5f4db 100644
> --- a/src/intel/vulkan/anv_queue.c
> +++ b/src/intel/vulkan/anv_queue.c
> @@ -542,8 +542,6 @@ anv_wait_for_bo_fences(struct anv_device *device,
>                          bool waitAll,
>                          uint64_t _timeout)
>   {
> -   int ret;
> -
>      /* DRM_IOCTL_I915_GEM_WAIT uses a signed 64 bit timeout and is supposed
>       * to block indefinitely timeouts <= 0.  Unfortunately, this was broken
>       * for a couple of kernel releases.  Since there's no way to know
> @@ -647,6 +645,7 @@ anv_wait_for_bo_fences(struct anv_device *device,
>               abstime.tv_nsec = abs_nsec;
>               abstime.tv_sec = MIN2(abs_sec, INT_TYPE_MAX(abstime.tv_sec));
>   
> +            MAYBE_UNUSED int ret;
>               ret = pthread_cond_timedwait(&device->queue_submit,
>                                            &device->mutex, &abstime);
>               assert(ret != EINVAL);




More information about the mesa-dev mailing list