[Mesa-dev] [PATCH] mesa: allow EXT_texture_compression_s3tc on ES2

[Erik Faye-Lund]

On Thu, 2018-10-18 at 15:42 -0400, Marek Olšák wrote:
> I think you need something like this:
> 
https://cgit.freedesktop.org/~mareko/mesa/commit/?h=amd-extension-pack&id=ad774f9db1d735811a8d830ad90a2f8208aa0a7b
> 

Thanks, this looks correct to me.

I've ported some of the piglit s3tc tests to gles2, and they all seem
to pass with your patch:

https://patchwork.freedesktop.org/series/51467/

Do you mind if I add a "Tested-by"-tag and submit a v2 with your patch
instead?

> I also have:
> rgtc: 
> https://cgit.freedesktop.org/~mareko/mesa/commit/?h=amd-extension-pack&id=c9c0ffc2d40f0119fb31bf0515f321cd877090dd
> bptc: 
> https://cgit.freedesktop.org/~mareko/mesa/commit/?h=amd-extension-pack&id=111255b6f8b85119da2c5d29dc19abc422fd7a12
> 
> and no time to test them.
> 
> Marek
> 
> On Thu, Oct 18, 2018 at 11:05 AM Erik Faye-Lund <
> erik.faye-lund at collabora.com> wrote:
> > The extension is written against both GL 1.2 and GLES 2.0, so let's
> > also enable it on GLES 2.0.
> > 
> > Signed-off-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
> > ---
> >  src/mesa/main/extensions_table.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/mesa/main/extensions_table.h
> > b/src/mesa/main/extensions_table.h
> > index 09bf923bd0e..47db1583135 100644
> > --- a/src/mesa/main/extensions_table.h
> > +++ b/src/mesa/main/extensions_table.h
> > @@ -278,7 +278,7 @@ EXT(EXT_texture_buffer                      ,
> > OES_texture_buffer
> >  EXT(EXT_texture_compression_dxt1            ,
> > ANGLE_texture_compression_dxt          , GLL, GLC, ES1, ES2, 2004)
> >  EXT(EXT_texture_compression_latc            ,
> > EXT_texture_compression_latc           , GLL,  x ,  x ,  x , 2006)
> >  EXT(EXT_texture_compression_rgtc            ,
> > ARB_texture_compression_rgtc           , GLL, GLC,  x ,  x , 2004)
> > -EXT(EXT_texture_compression_s3tc            ,
> > EXT_texture_compression_s3tc           , GLL, GLC,  x ,  x , 2000)
> > +EXT(EXT_texture_compression_s3tc            ,
> > EXT_texture_compression_s3tc           , GLL, GLC,  x , ES2, 2000)
> >  EXT(EXT_texture_cube_map                    ,
> > ARB_texture_cube_map                   , GLL,  x ,  x ,  x , 2001)
> >  EXT(EXT_texture_cube_map_array              ,
> > OES_texture_cube_map_array             ,  x ,  x ,  x ,  31, 2014)
> >  EXT(EXT_texture_edge_clamp                  , dummy_true         
> >                    , GLL,  x ,  x ,  x , 1997)