[Mesa-dev] [Bug 108544] logic error in file configure.ac

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108544

            Bug ID: 108544
           Summary: logic error in file configure.ac
           Product: Mesa
           Version: 18.1
          Hardware: ARM
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Other
          Assignee: mesa-dev at lists.freedesktop.org
          Reporter: zhaowei.yuan at samsung.com
        QA Contact: mesa-dev at lists.freedesktop.org

Hi,

Following codes can be found from file configure.ac:

    drm)
        test "x$enable_gbm" = "xno" &&
                AC_MSG_ERROR([EGL platform drm needs gbm])
        DEFINES="$DEFINES -DHAVE_DRM_PLATFORM"
        ;;

It doesn't make sense, if enable_gbm is "no", then should output the error
message and stop auto-configuring

So, it seems it should be modified as:
    drm)
        if test "x$enable_gbm" = "xno"; then
                AC_MSG_ERROR([EGL platform drm needs gbm])
        fi
        DEFINES="$DEFINES -DHAVE_DRM_PLATFORM"
        ;;

If I'm right, I'd like to commit a patch to fix it

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181025/f70cf030/attachment-0001.html>