[Mesa-dev] [PATCH 2/2] st/nir: Drop unused parameter from st_nir_assign_uniform_locations().

Rob Clark robdclark at gmail.com
Thu Oct 25 14:20:35 UTC 2018


On Thu, Oct 25, 2018 at 5:22 AM Kenneth Graunke <kenneth at whitecape.org> wrote:
>
> ARB programs won't have one of these, and we don't use it anyway.

Reviewed-by: Rob Clark <robdclark at gmail.com>

> ---
>  src/mesa/state_tracker/st_glsl_to_nir.cpp | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp
> index c15bd7e511b..dcde95cd609 100644
> --- a/src/mesa/state_tracker/st_glsl_to_nir.cpp
> +++ b/src/mesa/state_tracker/st_glsl_to_nir.cpp
> @@ -240,7 +240,6 @@ st_nir_lookup_parameter_index(const struct gl_program_parameter_list *params,
>  static void
>  st_nir_assign_uniform_locations(struct gl_context *ctx,
>                                  struct gl_program *prog,
> -                                struct gl_shader_program *shader_program,
>                                  struct exec_list *uniform_list, unsigned *size)
>  {
>     int max = 0;
> @@ -849,7 +848,7 @@ st_finalize_nir(struct st_context *st, struct gl_program *prog,
>     NIR_PASS_V(nir, nir_lower_atomics_to_ssbo,
>           st->ctx->Const.Program[nir->info.stage].MaxAtomicBuffers);
>
> -   st_nir_assign_uniform_locations(st->ctx, prog, shader_program,
> +   st_nir_assign_uniform_locations(st->ctx, prog,
>                                     &nir->uniforms, &nir->num_uniforms);
>
>     if (st->ctx->Const.PackedDriverUniformStorage) {
> --
> 2.19.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list