[Mesa-dev] [PATCH mesa] radv: remove duplicate brackets in version string
Bas Nieuwenhuizen
bas at basnieuwenhuizen.nl
Thu Oct 25 17:10:47 UTC 2018
How did you notice that? Anyway, can confirm,
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
On Thu, Oct 25, 2018 at 6:40 PM Eric Engestrom <eric.engestrom at intel.com> wrote:
>
> MESA_GIT_SHA1 resolves to either an empty "" string if not build from git,
> or " (git-DEADBEEF)" if it is. No need to wrap it in additional "()".
>
> Fixes: 9d40ec2cf6ec6d3d9d78 "radv: Add support for VK_KHR_driver_properties."
> Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
> ---
> src/amd/vulkan/radv_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> index 8e43a3aab58620dfc756..73d0f9fe02db6bc74643 100644
> --- a/src/amd/vulkan/radv_device.c
> +++ b/src/amd/vulkan/radv_device.c
> @@ -1218,7 +1218,7 @@ void radv_GetPhysicalDeviceProperties2(
>
> memset(driver_props->driverInfo, 0, VK_MAX_DRIVER_INFO_SIZE_KHR);
> snprintf(driver_props->driverInfo, VK_MAX_DRIVER_INFO_SIZE_KHR,
> - "Mesa " PACKAGE_VERSION " (" MESA_GIT_SHA1 ")"
> + "Mesa " PACKAGE_VERSION MESA_GIT_SHA1
> " (LLVM %d.%d.%d)",
> (HAVE_LLVM >> 8) & 0xff, HAVE_LLVM & 0xff,
> MESA_LLVM_VERSION_PATCH);
> --
> Cheers,
> Eric
>
More information about the mesa-dev
mailing list