[Mesa-dev] [PATCH v2] intel/tools: fix resource leak

asimiklit.work at gmail.com asimiklit.work at gmail.com
Fri Oct 26 14:29:34 UTC 2018


From: Andrii Simiklit <andrii.simiklit at globallogic.com>

Some memory and file descriptors are not freed/closed.

v2: fixed case where we skipped the 'aub' variable initialization

Signed-off-by: Andrii Simiklit <andrii.simiklit at globallogic.com>
---
 src/intel/tools/error2aub.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/intel/tools/error2aub.c b/src/intel/tools/error2aub.c
index 8a23d5ef1e..2b850ce885 100644
--- a/src/intel/tools/error2aub.c
+++ b/src/intel/tools/error2aub.c
@@ -326,6 +326,16 @@ main(int argc, char *argv[])
 
    aub_write_exec(&aub, batch_addr, aub_gtt_size(&aub), I915_EXEC_RENDER);
 
+   free(out_filename);
+   free(line);
+   if(err_file) {
+      fclose(err_file);
+   }
+   if(aub.file) {
+      aub_file_finish(&aub);
+   } else if(aub_file) {
+      fclose(aub_file);
+   }
    return EXIT_SUCCESS;
 }
 
-- 
2.17.1



More information about the mesa-dev mailing list