[Mesa-dev] [PATCH v1 1/5] meson: compilation flags for sse

[Dylan Baker]

CC'ing Matt and Emil.

This will make the code non-portable from an SSE capable system to a non-sse
capable system. That's a pretty old system at this point (Pentium III and Athlon
XP), and I don't personaly care, but it's quite possible that distros do care.

What do you guys think?

Dylan

Quoting Sergii Romantsov (2018-10-26 03:05:24)
> While building of 32bit Mesa gcc doesn't specifies __SSE__ by default.
> So it has to be done manually by flag '-msee'.
> Added support of such specification to build-system.
> 
> CC: Dylan Baker <dylan at pnwbakers.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108560
> Signed-off-by: Sergii Romantsov <sergii.romantsov at globallogic.com>
> ---
>  meson.build | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/meson.build b/meson.build
> index 505cc6c..f335434 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -806,6 +806,12 @@ if cc.has_argument('-fvisibility=hidden')
>    c_vis_args += '-fvisibility=hidden'
>  endif
>  
> +c_sse_args = []
> +# x86_64 enables -msse by default, on x86 it required to be enabled manually
> +if host_machine.cpu_family() == 'x86' and cc.has_argument('-msse')
> +  c_sse_args += ['-msse', '-mstackrealign']
> +endif
> +
>  # Check for generic C++ arguments
>  cpp_args = []
>  foreach a : ['-Wall', '-fno-math-errno', '-fno-trapping-math',
> @@ -836,6 +842,12 @@ if cpp.has_argument('-fvisibility=hidden')
>    cpp_vis_args += '-fvisibility=hidden'
>  endif
>  
> +cpp_sse_args = []
> +# x86_64 enables -msse by default, on x86 it required to be enabled manually
> +if host_machine.cpu_family() == 'x86' and cpp.has_argument('-msse')
> +  cpp_sse_args += ['-msse', '-mstackrealign']
> +endif
> +
>  # Check for C and C++ arguments for MSVC2013 compatibility. These are only used
>  # in parts of the mesa code base that need to compile with old versions of
>  # MSVC, mainly common code
> -- 
> 2.7.4
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181026/c4805ea1/attachment-0001.sig>