[Mesa-dev] [PATCH] configure.ac: make judgement logic cleaner

Zhaowei Yuan zhaowei.yuan at samsung.com
Mon Oct 29 07:08:26 UTC 2018


The purpose of judegment here is to output error message
and abort configure procedure if gbm is not enabled, the
original statement makes it work, however, its logic is
not clear and easy to make people confused.

Signed-off-by: Zhaowei Yuan <zhaowei.yuan at samsung.com>
---
 configure.ac | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 6342458..e754061 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1866,8 +1866,9 @@ for plat in $platforms; do
         ;;
 
     drm)
-        test "x$enable_gbm" = "xno" &&
+        if test "x$enable_gbm" = "xno"; then
                 AC_MSG_ERROR([EGL platform drm needs gbm])
+        fi
         DEFINES="$DEFINES -DHAVE_DRM_PLATFORM"
         ;;
 
-- 
2.7.4



More information about the mesa-dev mailing list