[Mesa-dev] [PATCH 00/14] Various cleanups on display lists and draw code.

[Mathias.Froehlich at gmx.net]

From: Mathias Fröhlich <Mathias.Froehlich at gmx.net>

Hi,

The series collects some of that cleanup opportunities that I found while
working on the vao changes from this spring.
There are two groups of changes. The first bunch removes unreachable
code paths from the dlist code and removes related functions and flags.
That is all done step by step with hopefully easy to review and provable
steps.
The second bunch of changes clean up and centralize draw related code that
is no longer someting vbo module specific.

The series went through intels CI system without failures.

Please review!
thanks and best

Mathias


Mathias Fröhlich (14):
  vbo: Remove unused vbo_save_fallback function.
  vbo: Remove the VBO_SAFE_FALLBACK flag.
  vbo: Remove set but not used weak field from _mesa_prim.
  vbo: Remove VBO_SAVE_PRIM_WEAK from vbo_save_NotifyBegin calls.
  vbo: Test for VBO_SAVE_PRIM_WEAK in _mesa_prim::mode is false.
  vbo: Remove the always false branch dlist replay.
  vbo: Remove the now unused VBO_SAVE_PRIM_WEAK define.
  vbo: Move no_current_update out of _mesa_prim.
  vbo: Make no_current_update an argument to vbo_save_NotifyBegin.
  vbo: Preserve vbo_save::no_current_update on primitive restart.
  vbo: Pull the _mesa_set_draw_vao calls out of the if clauses.
  mesa/vbo: Move src/mesa/vbo/vbo_exec_array.c -> src/mesa/main/draw.c
  mesa/vbo: Move _vbo_draw_indirect -> _mesa_draw_indirect
  mesa: Collect all the draw functions in draw.{h,c}.

 src/mapi/glapi/gen/gl_genexec.py              |   4 +-
 src/mesa/Makefile.sources                     |   3 +-
 src/mesa/drivers/common/driverfuncs.c         |   4 +-
 src/mesa/drivers/common/meta.c                |   1 +
 src/mesa/main/dlist.c                         |   2 +-
 .../{vbo/vbo_exec_array.c => main/draw.c}     | 721 ++++++++++--------
 src/mesa/main/draw.h                          | 159 ++++
 src/mesa/main/varray.c                        |  43 --
 src/mesa/main/varray.h                        |  53 --
 src/mesa/meson.build                          |   3 +-
 src/mesa/state_tracker/st_cb_rasterpos.c      |   1 -
 src/mesa/vbo/vbo.h                            |  49 +-
 src/mesa/vbo/vbo_context.c                    |  74 --
 src/mesa/vbo/vbo_exec_api.c                   |   1 -
 src/mesa/vbo/vbo_exec_draw.c                  |   3 +-
 src/mesa/vbo/vbo_save.c                       |  17 +-
 src/mesa/vbo/vbo_save.h                       |   7 +-
 src/mesa/vbo/vbo_save_api.c                   |  38 +-
 src/mesa/vbo/vbo_save_loopback.c              |  30 +-
 19 files changed, 590 insertions(+), 623 deletions(-)
 rename src/mesa/{vbo/vbo_exec_array.c => main/draw.c} (73%)
 create mode 100644 src/mesa/main/draw.h

-- 
2.17.2