[Mesa-dev] [PATCH 3/4] radv/winsys: fix buffer deletion in the sysmem path

Samuel Pitoiset samuel.pitoiset at gmail.com
Tue Oct 30 10:41:19 UTC 2018


In case we failed to submit the CS correctly.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
---
 src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
index 5f621ec3fb..75f1c47fd9 100644
--- a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
+++ b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
@@ -1094,10 +1094,11 @@ static int radv_amdgpu_winsys_cs_submit_sysmem(struct radeon_winsys_ctx *_ctx,
 
 		for (unsigned j = 0; j < number_of_ibs; j++) {
 			ws->buffer_destroy(bos[j]);
-			if (r)
-				return r;
 		}
 
+		if (r)
+			return r;
+
 		i += cnt;
 	}
 	if (fence)
-- 
2.19.1



More information about the mesa-dev mailing list