[Mesa-dev] [PATCH v3 1/2] i965/batch: avoid reverting batch buffer if saved state is an empty

Kenneth Graunke kenneth at whitecape.org
Tue Oct 30 19:14:48 UTC 2018

On Friday, October 26, 2018 1:06:52 AM PDT andrey simiklit wrote:
> Hi,
> Could you please help me with a push. I don't have a right for it :-)
> Thanks,
> Andrii.

Thanks for fixing these up!

While we're here, there are several other variables where we track the
last known state of the GPU, which can go wrong if we roll back the
commands that actually set that state:

    We may have rolled back a 3DSTATE_CONSTANT_* emit, so need to set

        brw->*.base.push_constants_dirty = true;

    We may have rolled back a 3DSTATE_URB_* emit, so need to set
        brw->urb.{vghd}size = something that won't match so we re-emit

    We may have rolled back 3DSTATE_DEPTH_BUFFER & friends, so we need
    to somehow deal with:


There may be more.

Bonus points if you want to fix some of those up. :)  Thanks again!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181030/f057134a/attachment.sig>

More information about the mesa-dev mailing list