[Mesa-dev] [PATCH] st/glsl_to_nir: fix next_stage gathering

[Marek Olšák]

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Sat, Oct 20, 2018 at 12:03 AM Timothy Arceri <tarceri at itsqueeze.com>
wrote:

> ffs() just returns the bit that is set, we need to know what
> stage that bit represents so use u_bit_scan() instead.
>
> Fixes: 2ca5d9548fc4 ("st/glsl_to_nir: gather next_stage in shader_info")
> ---
>  src/mesa/state_tracker/st_glsl_to_nir.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp
> b/src/mesa/state_tracker/st_glsl_to_nir.cpp
> index 24776f7f9c4..18d5d308900 100644
> --- a/src/mesa/state_tracker/st_glsl_to_nir.cpp
> +++ b/src/mesa/state_tracker/st_glsl_to_nir.cpp
> @@ -373,7 +373,7 @@ st_glsl_to_nir(struct st_context *st, struct
> gl_program *prog,
>           ~prev_stages & shader_program->data->linked_stages;
>
>        nir->info.next_stage = stages_mask ?
> -         (gl_shader_stage) ffs(stages_mask) : MESA_SHADER_FRAGMENT;
> +         (gl_shader_stage) u_bit_scan(&stages_mask) :
> MESA_SHADER_FRAGMENT;
>     } else {
>        nir->info.next_stage = MESA_SHADER_FRAGMENT;
>     }
> --
> 2.17.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181030/6c5413b6/attachment.html>