[Mesa-dev] [PATCH 09/14] vbo: Make no_current_update an argument to vbo_save_NotifyBegin.

[Mathias Fröhlich]

Good Morning,

On Tuesday, 30 October 2018 13:24:50 CET Eric Engestrom wrote:
> > @@ -1294,7 +1294,7 @@ static void GLAPIENTRY
> >  _save_OBE_Rectf(GLfloat x1, GLfloat y1, GLfloat x2, GLfloat y2)
> >  {
> >     GET_CURRENT_CONTEXT(ctx);
> > -   vbo_save_NotifyBegin(ctx, GL_QUADS);
> > +   vbo_save_NotifyBegin(ctx, GL_QUADS, true);
> 
> I won't pretend to understand any of this code, but logic-wise I think
> this should be `false`, not `true`.
> If the change was on purpose, maybe it belongs in a separate patch with
> an explanation?

Good catch! That was actually not intended!
I have changed that locally to false!

Thanks
Mathias