[Mesa-dev] [RFC] freedreno: import libdrm_freedreno + redesign submit
emil.l.velikov at gmail.com
Wed Oct 31 10:18:54 UTC 2018
On Tue, 30 Oct 2018 at 18:15, Rob Clark <robdclark at gmail.com> wrote:
> On Tue, Oct 30, 2018 at 1:34 PM Emil Velikov <emil.l.velikov at gmail.com> wrote:
> > On Tue, 30 Oct 2018 at 17:19, Rob Clark <robdclark at gmail.com> wrote:
> > > On Tue, Oct 30, 2018 at 11:27 AM Emil Velikov <emil.l.velikov at gmail.com> wrote:
> > > > > > NOTE: if bisecting a build error takes you hear, try a clean build.
> > > > > > There are a bunch of ways things can go wrong if you still have
> > > > > > libdrm_freedreno cflags.
> > > > >
> > > > > Good note!
> > > > > (and s/hear/here/)
> > > > >
> > > > Or to make the note disappear and minimise the chance to even getting
> > > > here you can try the following:
> > > > - patch 1 - dummy copy, mention the sha used as base
> > > > - patch 2/3/4 - wire up Autoconf/Android/meson
> > > > - patch 5/... - polish (remove freedreno_drmif.h includes and others)
> > > >
> > >
> > > fwiw, I'm not planning to remove libdrm_freedreno any time soon,
> > > because (a) new libdrm vs old mesa combo, and (b) I do have some other
> > > small utils that use libdrm_freedreno. I'm just planning to not
> > > change it.
> > >
> > Fair enough. I guess those tools will not benefit from the reduced CPU
> > cycled, to warrant a rewrite.
> > I would greatly appreciate if you can split things as mentioned earlier though.
> > After all you've used the exact same approach to create the lot.
> Too late on that, it is already merged. I had considered trying to
> split up into (1) import, plus (2) redesign, but there was too much
> churn related to converting the code over to mesa utils / data
> structures / etc, so I gave up.
Well I'm slow - serves me right. The argument sound quite meh... as
said you've already followed that approach while preparing it.
More information about the mesa-dev