[Mesa-dev] [Bug 106833] glLinkProgram is expected to fail when vertex attribute aliasing happens on ES3.0 context or later

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106833

Tapani Pälli <lemody at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Tapani Pälli <lemody at gmail.com> ---
Fixed by following commit. Note that since the rule applies to ES only, this
fixes the conformance when running chrome with '--use-gl=egl'. Let me know if
this is not sufficient from Chrome or WebGL perspective. It could be the Angle
needs to be fixed when running on desktop GL.

--- 8< ---
commit 27f1298b9d95899c4061294e384fadfd1c0a1b44
Author: Tapani Pälli <tapani.palli at intel.com>
Date:   Wed Jun 6 14:19:16 2018 +0300

    glsl/linker: validate attribute aliasing before optimizations

    Patch does a 'dry run' of assign_attribute_or_color_locations before
    optimizations to catch cases where we have aliasing of unused attributes
    which is forbidden by the GLSL ES 3.x specifications.

    We need to run this pass before unused attributes may be removed and with
    attribute binding information from program, therefore we re-use existing
    pass in linker rather than attempt to write another one.

    This fixes WebGL2 test 'gl-bindAttribLocation-aliasing-inactive' and
    Piglit test 'gles-3.0-attribute-aliasing'.

    Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106833
    Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181031/852d67b0/attachment.html>