[Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match
imirkin at alum.mit.edu
Wed Oct 31 17:03:52 UTC 2018
On Wed, Oct 31, 2018 at 12:37 PM Erik Faye-Lund
<erik.faye-lund at collabora.com> wrote:
> On Wed, 2018-10-31 at 12:01 -0400, Ilia Mirkin wrote:
> > I had to do a double (or triple) take on this logic as well. Part of
> > the subtlety is that the fallback only applies for ES when there's a
> > match but no exact match. Probably good to mention this.
> Yeah, that makes sense. I thought I mentioneded this in the commit
> message, but perhaps you want that to be more explicit than the "In
> GLES, "-introduction?
> How about I simply add something like "This fallback should only affect
> GLES." at the end of the commit message?
Yes, you did mention it in the commit message. But that's unlikely to
be visible when reading this code. I was thinking something in this
function's comments would be nice.
More information about the mesa-dev