[Mesa-dev] [PATCH mesa] meson: hide warnings from external project `gtest`

[Eric Engestrom]

On Wednesday, 2018-10-31 10:15:40 -0700, Dylan Baker wrote:
> gtest doesn't generate any warnings, but this seems fine,

It does for me, because I have more warnings enabled locally :P

One that I'd like to eventually enable (and as an error if possible)
is -Wundef to warn when undefined macros are used; in my experience at
$PREVIOUS_JOB this warning very often indicates actual bugs.

> Reviewed-by: Dylan Baker <dylan at pnwbakers.com>

Thanks :)

> 
> Quoting Eric Engestrom (2018-10-31 09:43:03)
> > gtest is an external project that is copied in this tree for technical
> > reasons, but isn't maintained by us, so its warnings are irrelevant.
> > 
> > Cc: Emil Velikov <emil.l.velikov at gmail.com>
> > Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
> > ---
> >  src/gtest/meson.build | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/gtest/meson.build b/src/gtest/meson.build
> > index 91a49240416951731eb9..23c21423d008d71fc8f9 100644
> > --- a/src/gtest/meson.build
> > +++ b/src/gtest/meson.build
> > @@ -22,6 +22,7 @@ libgtest = static_library(
> >    'gtest',
> >    files('src/gtest-all.cc', 'src/gtest_main.cc'),
> >    include_directories : include_directories('include'),
> > +  cpp_args : '-w',
> >    build_by_default : false,
> >  )
> >  
> > -- 
> > Cheers,
> >   Eric
> >