[Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Add VEGA20 support.

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Tue Sep 4 16:21:34 UTC 2018


On Tue, Sep 4, 2018 at 6:03 PM Dylan Baker <dylan at pnwbakers.com> wrote:
>
> Quoting Bas Nieuwenhuizen (2018-09-02 17:35:49)
> > Just mirror the radeonsi bits. Since this is just adding the extra
> > switch entries for new HW I think this should be fine for stable.
> >
> > CC: <mesa-stable at lists.freedesktop.org>
> > ---
> >  src/amd/vulkan/radv_pipeline.c | 1 +
> >  src/amd/vulkan/si_cmd_buffer.c | 1 +
> >  2 files changed, 2 insertions(+)
> >
> > diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
> > index 13477231a4f..1741d5e9047 100644
> > --- a/src/amd/vulkan/radv_pipeline.c
> > +++ b/src/amd/vulkan/radv_pipeline.c
> > @@ -2539,6 +2539,7 @@ radv_pipeline_generate_binning_state(struct radeon_cmdbuf *cs,
> >         switch (pipeline->device->physical_device->rad_info.family) {
> >         case CHIP_VEGA10:
> >         case CHIP_VEGA12:
> > +       case CHIP_VEGA20:
> >                 context_states_per_bin = 1;
> >                 persistent_states_per_bin = 1;
> >                 fpovs_per_batch = 63;
> > diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c
> > index 2cfa7f4c2c3..435878c3722 100644
> > --- a/src/amd/vulkan/si_cmd_buffer.c
> > +++ b/src/amd/vulkan/si_cmd_buffer.c
> > @@ -340,6 +340,7 @@ si_emit_config(struct radv_physical_device *physical_device,
> >                 switch (physical_device->rad_info.family) {
> >                 case CHIP_VEGA10:
> >                 case CHIP_VEGA12:
> > +               case CHIP_VEGA20:
> >                         pc_lines = 4096;
> >                         break;
> >                 case CHIP_RAVEN:
> > --
> > 2.18.0
> >
>
> Hi Bas,
>
> I'm not going to pull this for 18.1 since radeonsi doesn't support Vega 20 in
> 18.1, I think this should be fine for 18.2 though since radeonsi has Vega 20
> support.

Yep agreed. Thanks!
>
> Dylan


More information about the mesa-dev mailing list