[Mesa-dev] [PATCH 2/2] loader/dri3: Don't wait for fence of old buffer when re-allocating it

[Olivier Fourdan]

Hi
On Tue, Sep 4, 2018 at 6:23 PM Michel Dänzer <michel at daenzer.net> wrote:
>
> From: Michel Dänzer <michel.daenzer at amd.com>
>
> We only need to wait for the fence before drawing to a buffer, not
> before reading from it.
>
> This might avoid hangs when re-allocating the fake front buffer, similar
> to the previous change. But I haven't seen any hard evidence that this
> was actually happening in practice.
>
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> ---
>  src/loader/loader_dri3_helper.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c
> index 6c162553f33..c173a61ba06 100644
> --- a/src/loader/loader_dri3_helper.c
> +++ b/src/loader/loader_dri3_helper.c
> @@ -1778,7 +1778,6 @@ dri3_get_buffer(__DRIdrawable *driDrawable,
>            && buffer) {
>
>           /* Fill the new buffer with data from an old buffer */
> -         dri3_fence_await(draw->conn, draw, buffer);
>           if (!loader_dri3_blit_image(draw,
>                                       new_buffer->image,
>                                       buffer->image,
> --
> 2.19.0.rc1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Both patches are successfully:

Tested-by: Olivier Fourdan <ofourdan at redhat.com>

Cheers,
Olivier