[Mesa-dev] [PATCH mesa] meson: vc4 requires libdrm too

[Emil Velikov]

On 5 September 2018 at 12:06, Eric Engestrom <eric.engestrom at intel.com> wrote:
> According to 4fc0ebdff55419965919e "broadcom/vc4: Bump libdrm requirement",
> vc4 is a special case here as it does not use its libdrm_vc4, but only depends
> on core libdrm.
>
> The way the version check was added however means that the core libdrm
> dependency() needs to be explicitly required if vc4 is being built.
>
> Fixes: 4fc0ebdff55419965919e "broadcom/vc4: Bump libdrm requirement"
> Cc: Eric Anholt <eric at anholt.net>
> Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
> ---
>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 55416020402620a2565e..474d8692a956b0151b5c 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1140,7 +1140,7 @@ endforeach
>  with_gallium_drisw_kms = false
>  dep_libdrm = dependency(
>    'libdrm', version : '>=' + _drm_ver,
> -  required : with_dri2 or with_dri3
> +  required : with_dri2 or with_dri3 or with_gallium_vc4

Normally you'd want this to be a "gallium_drivers contains more than swrast/swr"
The st/dri/dri2.c needs to talk to the kernel, so it's needed in general.

HTH
Emil