[Mesa-dev] [PATCH 4/4] i965/fs: include multisamplers on image_intrinsic_coord_components

Alejandro PiƱeiro apinheiro at igalia.com
Wed Sep 5 14:11:01 UTC 2018


This is the second patch needed to fix the following piglit tests:

   tests/spec/arb_gl_spirv/linker/uniform/multisampler.shader_test
   tests/spec/arb_gl_spirv/linker/uniform/multisampler-array.shader_test

Although in this case it doesn't affect so many borrowed tests, as
there aren't too many tests using multisamplers on Intel.

It is worth to note that this patch is also needed when those tests
are run on GLSL mode (using the --glsl option). Although most Intel
drivers would not be able to run/execute tests using multisamplers, as
GL_MAX_IMAGE_SAMPLES is zero, technically those tests are expected to
link correctly, so linking tests should pass.
---
 src/intel/compiler/brw_fs_nir.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp
index 2fef050f81a..eef3453672c 100644
--- a/src/intel/compiler/brw_fs_nir.cpp
+++ b/src/intel/compiler/brw_fs_nir.cpp
@@ -3815,6 +3815,8 @@ image_intrinsic_coord_components(nir_intrinsic_instr *instr)
       return 3;
    case GLSL_SAMPLER_DIM_BUF:
       return 1;
+   case GLSL_SAMPLER_DIM_MS:
+      return 2;
    default:
       unreachable("Invalid image dimension");
    }
-- 
2.14.1



More information about the mesa-dev mailing list